search

Quaffel / get-me-drunk-efficiently

Webservice providing cocktail recommendations based on how drunk you want to be
4 stars 0 forks source link

Prune cocktails made from ingredients that are (partially) missing quantities #40

Open Quaffel opened 3 years ago

Quaffel commented 3 years ago

At present, we simply ignore ingredients that are lacking a quantity. In some cases, however, this behavior may yield odd results.

The cocktail "El Presidente" contains only a single ingredient that holds quantity information. As we discard the other ingredients, it appears as the cocktail is made from a single ingredient. Even worse, some of the missing ingredients are alcoholic and thus not respected in our calculation.

We can either guess the amount or prune the entire cocktail. As we can really screw up doing the former, I'll investigate the impact of doing the latter first.

Quaffel commented 3 years ago

@nhaef Latest query can be found in docs/wd-query (subject to #6). Just prune the cocktails that have no or incomplete ingredients. Please ensure that the amount of available drinks stays roughly the same. If there's a strong deviation, please let me know.