search

QuailAutomation / openhab2-addons

The next-generation open Home Automation Bus (openHAB)
Eclipse Public License 2.0
8 stars 7 forks source link

Omnilink binding cleanup #141

Closed digitaldan closed 5 years ago

digitaldan commented 5 years ago
digitaldan commented 5 years ago

@boc-tothefuture and @craigham please take a look at this PR. I did a bunch up cleanup around using the shared executors in openHAB which should simplify the reconnect logic and polling logic. I also cleaned up various warnings, moved to using annotations for the OSGI DI and generally did some house keeping. Once we get through this, i will submit a PR that moves to the new build system, but this will require you to remove and import the project back into eclipse, so its a little disruptive. Thanks!

boc-tothefuture commented 5 years ago

@digitaldan Thanks for doing this. FYI, I have a fairly big PR going on here as well, adding output, generic unit support and lumina support. People are testing it over in the openhab forum. Once it clears testing I will merge these changes in and submit a PR.

Once we move to the new build system we are building against 2.5, right?

digitaldan commented 5 years ago

This PR is building against 2.5 right now, i'm not sure if you can load it in a 2.4 system, but its worth a shot trying out if thats important. Many times they are backwards compatible.