search

QualInsight / qualinsight-plugins-sonarqube-smell

Code Smells plugin for SonarQube and companion Java library
GNU Lesser General Public License v3.0
47 stars 13 forks source link

Remove SonarQube dependencies from annotation jar #24

Closed tsjensen closed 8 years ago

tsjensen commented 8 years ago

Hi,

I would like to suggest removing the dependency on the SonarQube API from the annotation jar. I believe the dependency is in fact not needed. We have just started using the WTF plugin in an larger development project, and the enormous amount of JARs being pulled into the classpath by the WTF API jar is prohibitive.

I hope that's ok with you. Thank you for this really nice plugin - good idea!

All the best --Thomas

pawlakm commented 8 years ago

Hi Thomas,

Thanks for this PR and your feedback. SQ's API is indeed not required, my bad. I'll merge this PR this evening and it will be available for 1.0.4

Cheers,

Michel

Le 14 oct. 2015 à 14:00, Thomas Jensen notifications@github.com a écrit :

Hi,

I would like to suggest removing the dependency on the SonarQube API from the annotation jar. I believe the dependency is in fact not needed. We have just started using the WTF plugin in an larger development project, and the enormous amount of JARs being pulled into the classpath by the WTF API jar is prohibitive.

I hope that's ok with you. Thank you for this really nice plugin - good idea!

All the best --Thomas

You can view, comment on, or merge this pull request online at:

https://github.com/QualInsight/qualinsight-plugins-sonarqube-wtf/pull/24

Commit Summary

Remove SonarQube dependencies from 'qualinsight-plugins-sonarqube-wtf-api' artifact File Changes

M api/pom.xml (17) Patch Links:

https://github.com/QualInsight/qualinsight-plugins-sonarqube-wtf/pull/24.patch https://github.com/QualInsight/qualinsight-plugins-sonarqube-wtf/pull/24.diff — Reply to this email directly or view it on GitHub.

tsjensen commented 8 years ago

No problem, thanks for merging! Can you foresee already when we will have the 1.0.4 release?

pawlakm commented 8 years ago

It was planned for the end of this week, however I just saw that there is a problem between Google's jsapi and SonarQube 5.2.1 usage of requirejs: https://github.com/QualInsight/qualinsight-plugins-sonarqube-wtf/issues/25

What version of SQ are you using (I cannot reproduce this issue with SQ 4.5.4) ?

pawlakm commented 8 years ago

Hi again Thomas,

I fixed the bug and started a vote for release for version 1.0.4 on SonarQube's Google group: https://groups.google.com/forum/#!topic/sonarqube/Hx9Pi-Vpp-w

It would be great if you could test the snapshot and give a feedback. Thanks in advance !

All the best,

Michel

tsjensen commented 8 years ago

We are using SQ 4.5.5, but did not encounter that problem. However, the widget crashed on me when there were no WTFs in the database (i.e. when you configure the widget before running any analyses).