QualInsight / qualinsight-plugins-sonarqube-smell

Code Smells plugin for SonarQube and companion Java library
GNU Lesser General Public License v3.0
47 stars 13 forks source link

New Code Smell Type proposal #54

Closed charlesmorin closed 7 years ago

charlesmorin commented 7 years ago

As discussed in the Google group thread, please add the following smell types:

Thread URL: https://groups.google.com/forum/#!topic/code-smells/F2X9fA2zmgM

Cheers

pawlakm commented 7 years ago

Hi Charles,

As further discussed by mail, I'll create the following types :

pawlakm commented 7 years ago

4.0.0-RC2-SNAPSHOT is working fine on latest LTS (with latest java plugin). Here is a screenshot of the widget:

screen shot 2017-01-19 at 21 36 45

pawlakm commented 7 years ago

Hi Charles,

To answer your question, version 4.0.0 is compatible with current LTS (5.6.x, tested with 5.6.4) and depends on java 4.4 plugin. See the requirements part of the documentation.

Can you please check if you agree with the default severity levels of the new smell types ?

Thanks in advance,

Michel

pawlakm commented 7 years ago

The plugin seems to work fine with SQ 6.2 as well. However, project dashboards having been removed by SonarSource, custom widget cannot be used anymore... Measure counting Code Smells reported by the plugin can however be seen in the "Measures" tab ("Code Smells" and "Technical Debt" sections). It's better than nothing, but it's ways less readable than a donut diagram...

charlesmorin commented 7 years ago

I'm good with the default severity levels. Makes perfect sense to me.

Thank you

pawlakm commented 7 years ago

Great, I close this issue then. I'll create a new RC this evening after having finished working on #56.