Release v1.5.4 & changes made in it missing on GitHub

[mkosik]

Hello, I noticed there is release 1.5.4 available: https://bintray.com/qualeams/Android-Face-Recognition-Deep-Learning-Library/Android-Face-Recognition-with-Deep-Learning-Library/1.5.4 from Jun 16, 2017, but it's not reflected in commits here, which are 3months old.

Could you please update this repo & let us know what fixes / improvements have been made in 1.5.4? Thank you a lot!

[sladomic]

Hi @mkosik

Version 1.5.4 is not official and was just for experimenting with some things.

In November I'll hopefully have some time to clean things up, but for the moment version 1.5.3 is the most recent version.

Regards, Michael

[mkosik]

Hi @sladomic,

thx for a quick response. I tried v1.5.4 in the demo project and yet didn't have any issues. Could you please at least tell meanwhile what changes / fixes are in it?

Regards, Miro

[sladomic]

Hi @mkosik

It's to get rid of the bad implementation for the storage of OpenCV Mat objects (currently stored as an xml, but with a very slow code).

You didn't encounter any errors, because you haven't used K-NN :)

Regards, Michael

[mkosik]

Thank you Michael.

Yep, now that I tried K-NN I can confirm, that there is currently a problem with new saving in v1.5.4, throwing a following exception:

E/cv::error(): OpenCV Error: Assertion failed (src.type() == CV_8UC1 || src.type() == CV_8UC3 || src.type() == CV_8UC4) in void Java_org_opencv_android_Utils_nMatToBitmap2(JNIEnv*, jclass, jlong, jobject, jboolean), file /build/master_pack-android/opencv/modules/java/generator/src/cpp/utils.cpp, line 98

E/org.opencv.android.Utils: nMatToBitmap catched cv::Exception: /build/master_pack-android/opencv/modules/java/generator/src/cpp/utils.cpp:98: error: (-215) src.type() == CV_8UC1 || src.type() == CV_8UC3 || src.type() == CV_8UC4 in function void Java_org_opencv_android_Utils_nMatToBitmap2(JNIEnv*, jclass, jlong, jobject, jboolean)