Property type builders, tests

[sokolovsv90]

As discussed in pull request #48 All tests passed

[borismod]

@sokolovsv90 are you sure the build passes?

[sokolovsv90]

@borismod why do you ask? It does and all the tests pass. I almost feel like I'm missing something

[borismod]

For some reason there are $ instead of @

if (!validationMap.ContainsKey(validation))
 +                Assert.Inconclusive($"Wrong {nameof(validation)} argument value passed");
 +            validationMap[validation]();

http://teamcity.codebetter.com/viewLog.html?buildId=215162&tab=buildResultsDiv&buildTypeId=FluentTc_FluentTcDevelop

[sokolovsv90]

Oh... theese are special characters for string interpolation introduced in c# 6.0. I certainly can fix that, which version of msbuild do You use?

[borismod]

Microsoft Visual Studio 2013

[sokolovsv90]

Should work now

[borismod]

@sokolovsv90 it get's better:

[sokolovsv90]

bah, forgot that this was also a feature of c#6 :)

[sokolovsv90]

Should work now v.2

[borismod]

@sokolovsv90 this is a great contribution and this is exactly the way like I would like to see it. just a few minor comments:

1. Replace Append with Append format
2. Use const instead of inline strings
3. Replace Verify.That with FluentAssertions
4. Make sure all new code is covered by unit tests. For example, the following methods are not: BuildParameterTypeBuilder.AsCheckbox and BuildParameterTypeBuilder .AsText
5. Add at least one Acceptance Test for each type: Select, CheckBox, Password, Normal. The below edge case is not unit tested:

I am sorry for being so "hard" and I know you did a great job. I'm just trying to keep high standards in this project. I hope you'll understand

[borismod]

@sokolovsv90 I assume that I was too hard to contributors. I really appreciate your contribution and I will accept your pull request as is. Can you just resolve the conflicts?

[sokolovsv90]

I understand your concerns and totally agree with you in terms of keeping high standards, but I simply haven't noticed how my own stuff got piled up and owerwhelmed me a bit. I'm truly sorry that I couldn't meet all the requirements (and I wish I had time to), but I'm glad you accepted that PR as is, thanks!

[borismod]

@sokolovsv90 FluentTc was published to nuget with your contribution, so you're welcome to install its latest package. I would like to thank you for your contribution and will be glad to see you contributing in the future. I'll try to be nicer :smile:

[borismod]

@sokolovsv90 what's your full name, so I could give you a credit on contributors list?