Comment for testing build

QualiSystems / FluentTc

:ocean: :two_men_holding_hands: :office: Integrate with TeamCity fluently

https://www.nuget.org/packages/fluenttc

Apache License 2.0

44 stars 35 forks source link

Comment for testing build #65

Closed TomerAdmon closed 8 years ago

TomerAdmon commented 8 years ago

now we can trigger build with those properties:

personal build
comment
queue on top
clean sources
require rebuild dependencies

acceptance tests were fixed.

borismod commented 8 years ago

@TomerAdmon, great contribution :+1: I wrote a few minor notes, could you take a look :question:

TomerAdmon commented 8 years ago

Hi, Thanks for the review. 1) fixed 2) fixed + add a test 3) regarding the ==true, since this is a nullable bool, we need to use the ==True (see here) 4) regarding the "if ( moreOptions.TriggeringOptions.HasValue )", we check that the moreOptions is not null, and if it's not null it means we initialized the ctor that created a new TriggeringOptions... so no need to test it....