Build Properties

[nex-54]

TeamCity api provides Properties for build(/app/rest/builds/id:{id}). Need to add Properties to Build class.

Issue #69

Checklist

• [x] All unit tests passed on build server
• [x] Acceptance test(s) covers new/modified functionality
• [ ] Code coverage is at least the same or higher
• [x] Breaking change in public API

var myProperty = new RemoteTc().Connect( => .ToHost("tc")) .GetBuild(123456).Properties.Property.Where(p => p.Name == "MyProperty");

[borismod]

@nex-54 thank you for your contribution!

Have you committed unit tests and acceptance tests :question:

Please make sure build passes after your changes: http://teamcity.codebetter.com/viewType.html?buildTypeId=FluentTc_FluentTcDevelop&branch_FluentTc=70%2Fmerge&tab=buildTypeStatusDiv

[nex-54]

@borismod i will check it.

[nex-54]

@borismod all tests are green. The only problem is smaller statement coverage. I'm not sure it is good idea to commit test for property add. But i can add test for BuildModelToBuildConverter to check if this property is ok after call ConvertToBuild. I'm new on github, so should i do that or something else?

[nex-54]

@borismod how can i check unit tests on build server before make pull request?

[borismod]

Build server runs only from branches and pull requests. Can you run the tests locally?

I am afraid that in order to improve code coverage, you'll have to add some tests. On Jul 4, 2016 9:15 PM, "nex-54" notifications@github.com wrote:

@borismod https://github.com/borismod how can i check unit tests on build server before make pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/QualiSystems/FluentTc/pull/70#issuecomment-230336533, or mute the thread https://github.com/notifications/unsubscribe/AAM0MxgqjbfDrKVEcbLFFrIV5Nx63jMdks5qSU3JgaJpZM4JCHu- .

[nex-54]

Done. Just figured out i take branch from master. Should i take branch from dev next time?

[borismod]

@nex-54 thanks! I'll take a look later to approve it. Branching from master is the preferred option. Usually develop is even with master.

[borismod]

@nex-54 I appreciate your contribution and will merge this PR as well. It seems that this branch has conflicts. Can you please resolve them, so I could merge it?

[borismod]

@nex-54 what's your full name, so I could give you a credit on contributors list?

[nex-54]

@borismod conflicts are resolved my full name is Artem Kuznetsov