Build result from runner

QualiSystems / FluentTc

:ocean: :two_men_holding_hands: :office: Integrate with TeamCity fluently

https://www.nuget.org/packages/fluenttc

Apache License 2.0

44 stars 35 forks source link

Build result from runner #72

Closed nex-54 closed 8 years ago

nex-54 commented 8 years ago

Need ability to get buildId on post buildQueue #71

Checklist

[x] All unit tests passed on build server
[x] Acceptance test(s) covers new/modified functionality
[ ] Code coverage is at least the same or higher
[x] Breaking change in public API

var connection = new RemoteTc().Connect( => .ToHost("tc")); build = connection.RunBuildConfiguration(having => having.Id("bt2")); Thread.Sleep(10000); var status = connection.GetBuild(build.Id).Status;

borismod commented 8 years ago

@nex-54 I like this contribution very much. I always prefer methods that return value rather than do something with a "side-effect". Methods with return values are mush easier to test. Can you please do another step and address a few comments I left in the code?

nex-54 commented 8 years ago

All done except "percentage of statement coverage" - i'm not really sure what should i do to increase percentage of statement coverage. All my changes is covered by tests.

borismod commented 8 years ago

@nex-54 thank you for your contribution and I really appreciate your effort and patience to improve the coverage. I'll accept your PR and will add some tests later on to improve the coverage. Thanks again and welcome to the FluentTc contributors!

borismod commented 8 years ago

closes #71