search

QualiSystems / FluentTc

:ocean: :two_men_holding_hands: :office: Integrate with TeamCity fluently
https://www.nuget.org/packages/fluenttc
Apache License 2.0
44 stars 35 forks source link

Add support for running with both parameters and more options, fixes #83 #84

Closed evolvedlight closed 7 years ago

evolvedlight commented 7 years ago

Hi

This fixes #83 - sorry, missed the github keyword to associate these properly.

borismod commented 7 years ago

@evolvedlight thanks for your contribution. Can you please make sure the build passes? https://teamcity.jetbrains.com/viewLog.html?buildId=915857&buildTypeId=FluentTc_FluentTcDevelop

evolvedlight commented 7 years ago

Hi @borismod It looks like it already does for my merge build, just not the develop branch? https://teamcity.jetbrains.com/viewLog.html?buildId=915861&buildTypeId=FluentTc_FluentTcDevelop&tab=buildChangesDiv

borismod commented 7 years ago

No, it runs on the PR and it's not merged yet. https://teamcity.jetbrains.com/viewType.html?buildTypeId=FluentTc_FluentTcDevelop

borismod commented 7 years ago

The compilation of your code succeeded and all the tests passed as well. It's just the coverage is a little bit lower than it was. Can you please make it at least as it was or higher?

Thanks

evolvedlight commented 7 years ago

Hi

Sorry, you might have to give me more of a hint where to look. The current master is https://teamcity.jetbrains.com/viewLog.html?buildId=906978&tab=buildResultsDiv&buildTypeId=FluentTc and my changes are https://teamcity.jetbrains.com/viewLog.html?buildId=915861&tab=buildResultsDiv&buildTypeId=FluentTc_FluentTcDevelop. My changes have a slightly higher coverage % than master. The build you are linking to is related to a branch not from me, as far as I can tell (https://teamcity.jetbrains.com/viewLog.html?buildId=915857&buildTypeId=FluentTc_FluentTcDevelop&tab=buildChangesDiv shows the change not from me). I can add more tests, if you want, however I suspect it's not going to increase coverage significantly as the new code I've added looks like it's fully covered.

borismod commented 7 years ago

@evolvedlight my fault, you're right. Anyway I am going to migrate the CI to AppVeyor and to make the process of PR more friction-less that it's now. Thanks for your contribution!

borismod commented 7 years ago

Nuget published 0.0.0.210 https://www.nuget.org/packages/fluenttc

evolvedlight commented 7 years ago

Great, thanks!