QualiSystems / FluentTc

:ocean: :two_men_holding_hands: :office: Integrate with TeamCity fluently
https://www.nuget.org/packages/fluenttc
Apache License 2.0
44 stars 35 forks source link

Changes the spelling of "Cancelled" to "Canceled" (which TeamCity expects) #90

Closed phermens-coolblue closed 7 years ago

phermens-coolblue commented 7 years ago

Issue details

Cancelled is spelt "correctly" in this code-base, but TeamCity expects the US version: "canceled" (one L)

Relates to issue

Close #89

Checklist

Example of using new/modified functionality

        [Test]
        public void NotCancelled()
        {
            // Arrange
            var fixture = Auto.Fixture();
            var buildHavingBuilder = fixture.Create<BuildHavingBuilder>();

            // Act
            buildHavingBuilder.NotCancelled();

            // Assert
            buildHavingBuilder.GetLocator().Should().Be("canceled:False");
        }
borismod commented 7 years ago

Thanks for your contribution! Approved

phermens-coolblue commented 7 years ago

My pleasure, this is a great library. Thanks for creating it!

borismod commented 7 years ago

What's your full name? I am going to add you to the contributors list

phermens-coolblue commented 7 years ago

Haha, it's appreciated, but not required, thanks. My name is Pat Hermens.

borismod commented 7 years ago

Done:

https://github.com/QualiSystems/FluentTc/blob/master/CONTRIBUTORS.md

Boris Modylevsky

Agile Developer & Coach

Mobile: +972-526-377-300

Email: borismod@gmail.com

Blog: www.borismod.net

Twitter: https://twitter.com/bormod

Github: https://github.com/borismod

On Tue, Jan 31, 2017 at 10:14 PM, Pat notifications@github.com wrote:

Haha, it's appreciated, but not required, thanks. My name is Pat Hermens.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/QualiSystems/FluentTc/pull/90#issuecomment-276478610, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM0My4Y8izuAvjuQW-gvHxEaTuZMnPcks5rX5Y2gaJpZM4LzG-b .