search

QualiSystems / FluentTc

:ocean: :two_men_holding_hands: :office: Integrate with TeamCity fluently
https://www.nuget.org/packages/fluenttc
Apache License 2.0
44 stars 36 forks source link

Add access to information on the source of an artifact dependency #91

Closed 3breadt closed 7 years ago

3breadt commented 7 years ago

The ArtifactDependency class did not include information on the source build configuration of the dependency. This information is provided in the REST API in the "source-buildType" object.

I have added a new class SourceBuildType and added a corresponding property to the ArtifactDependency class. Now the build config information is automatically deserialized by EasyHttp.

borismod commented 7 years ago

Thanks for your contrubution.

It will be accepted when the code is covered by test(s) that reproduce, demonstrate the fix.

Also please create an issue and link it to your PR.

On Feb 2, 2017 11:09 AM, "Daniel Dreibrodt" notifications@github.com wrote:

The ArtifactDependency class did not include information on the source build configuration of the dependency. This information is provided in the REST API in the "source-buildType" object.

I have added a new class SourceBuildType and added a corresponding property to the ArtifactDependency class. Now the build config information is automatically deserialized by EasyHttp.

You can view, comment on, or merge this pull request online at:

https://github.com/QualiSystems/FluentTc/pull/91 Commit Summary

  • Add build config info for ArtifactDependencies
  • Add SourceBuildType property to ArtifactDependency

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/QualiSystems/FluentTc/pull/91, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM0M1XavViEKYxzzeSF_Lm21t1xpj86ks5rYZ1EgaJpZM4L03cv .

3breadt commented 7 years ago

I extended the unit test AcceptanceTests.GetBuildConfiguration_Id to cover artifact dependencies and the new SourceBuildType property.

This does not cover the actual deserialization of the REST response. But I found no quick way to mock the actual HTTP responses, which would have made the test much more meaningful.

I see that so far none of your unit tests actually do that, so I assume this unit test is acceptable for you.

Of course I manually tested the code against an actual TeamCity installation and it works just fine.

borismod commented 7 years ago

@3breadt thanks for your contribution