search

QualiSystems / FluentTc

:ocean: :two_men_holding_hands: :office: Integrate with TeamCity fluently
https://www.nuget.org/packages/fluenttc
Apache License 2.0
44 stars 35 forks source link

Refs #93. Now it's possible to modify descriptions #94

Closed GibbOne closed 7 years ago

GibbOne commented 7 years ago

Now it's possible to modify build configuration and project build descriptions.

According to:

borismod commented 7 years ago

@GibbOne it seems that the build failed: https://ci.appveyor.com/project/QualiSystems/fluenttc-m35t3/build/1.0.24

GibbOne commented 7 years ago

@borismod it's due to the fact that I'm using a C# 6 feature, but the build agent uses MSBuild 12.0. So "nameof" operator didn't exist. My mistake. I can use simple constant and fix it.

But do you think to pass to C# 6 in the future?

borismod commented 7 years ago

@GibbOne thank you for your contribution. Can you please add tests that cover the added functionality?

AcceptanceTests are a good place to look for examples: https://github.com/QualiSystems/FluentTc/blob/master/FluentTc.Tests/AcceptanceTests.cs

In addition you can also add unit tests

borismod commented 7 years ago

@GibbOne looks great! Thanks for your contribution. I am going to accept it. A new nuget package will be released soon.

GibbOne commented 7 years ago

Thank you!