QualiSystems / shellfoundry

:shell::factory: CloudShell package CLI build tool
Apache License 2.0
11 stars 20 forks source link

Command "new" entails crash in case incorrect path to local template #247

Closed turkovda closed 2 years ago

turkovda commented 4 years ago

Issue details

Command "new" entails crash in case incorrect path to local template

Traceback (most recent call last):
  File "C:\Users\dmit\Documents\Virtual_env\shellfoundry_1.2.15\Scripts\shellfoundry-script.py", line 11, in 
    load_entry_point('shellfoundry==1.2.15', 'console_scripts', 'shellfoundry')()
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\click\core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\click\core.py", line 697, in main
    rv = self.invoke(ctx)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\click\core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\click\core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\click\core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\shellfoundry\decorators\version_check.py", line 40, in decorator
    f(**kwargs)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\shellfoundry\bootstrap.py", line 60, in new
    NewCommandExecutor().new(name, template, version, python)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\shellfoundry\commands\new_command.py", line 87, in new
    self._import_local_template(name, running_on_same_folder, template, standards, python_version)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\shellfoundry\commands\new_command.py", line 178, in _import_local_template
    extra_content = self._get_template_params(repo_path=repo_path)
  File "c:\users\dmit\documents\virtual_env\shellfoundry_1.2.15\lib\site-packages\shellfoundry\commands\new_command.py", line 245, in _get_template_params
    with open(full_path, mode='r') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\dmit\\Downloads\\shellfoundry-tosca-networking-template-master\\cookiecutter.json'

Steps to reproduce

Run follow command (e.g.):

 shellfoundry new shell_name --template local:C:\Users\shellfoundry-tosca-networking-template-master

Affected version:

1.2.15

Affected platforms

Please fill additional environment specific configuration

turkovda commented 2 years ago

Fixed in 1.2.20