search

QualitativeDataRepository / AnnoREP-Frontend

Frontend for the AnnoREP tool to Restructure, Edit, and Publish annotations
https://anno-rep.org
MIT License
1 stars 1 forks source link

Axios 0.28 on Stage breaks dataset search. #176

Open adam3smith opened 1 month ago

adam3smith commented 1 month ago

Due to https://github.com/axios/axios/pull/4734 the requests to the mydata Dataverse API on stage include [] in the publicationStatus terms, so published_states[]=Published&published_states[]=Unpublished&published_states[]=Draft&published_states[]=In+Review instead of the correct published_states=Published&published_states=Unpublished&published_states=Draft&published_states=In%20Review

This breaks all dataset searches, both for ATI projects and for projects to turn into ATI projects

adam3smith commented 1 month ago

Comment from Jim:

Sounds good. He may have tried to fix it with https://github.com/QualitativeDataRepository/AnnoREP-Frontend/blob/87824fca11998487c53b1e549a2c7a61b00f93ad/pages/api/mydata-search.ts#L44 - not sure if it needs a different spelling as suggested by https://github.com/axios/axios/issues/1443#issuecomment-1706879463.

tohuynh commented 1 month ago

The upgrade to axios version must have made qs.stringify(params, { indices: false }) no longer removes []s. I'll try to take a look at the issue sometime this weekend if it's not urgent.

adam3smith commented 1 month ago

Not urgent -- production still is on 0.21 and works -- thanks!

Sent from my phone

On Wed, Jul 17, 2024, 21:36 To Huynh @.***> wrote:

The upgrade to axios version must have made qs.stringify(params, { indices: false }) no longer removes []s. I'll try to take a look at the issue sometime this weekend if it's not urgent.

— Reply to this email directly, view it on GitHub https://github.com/QualitativeDataRepository/AnnoREP-Frontend/issues/176#issuecomment-2235058097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7PWTMBYFGVLLRAOGI4Z3ZM4LYPAVCNFSM6AAAAABK7LPFJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZVGA2TQMBZG4 . You are receiving this because you authored the thread.Message ID: @.*** com>

tohuynh commented 1 month ago

It looks like 0.28.0 made breaking changes and paramsSerializer can longer be a function. The fix is supposedly in 0.28.1, I'll see if that fixes it.