search

QualityOps / wdio-timeline-reporter

34 stars 19 forks source link

Fix for afterTest Hook - test.passed to passed #51

Open himanshujane3 opened 3 years ago

himanshujane3 commented 3 years ago

test.passed is always undefined as there is no such property condition should be checking for passed property This was causing unnecessary screenshot after each test.

benzaremean commented 3 years ago

hi @himanshujane3 Ive not really looked at this with version 6 of wdio

himanshujane3 commented 3 years ago

Hi @benzaremean I have verified this with latest version of wdio - Please accept the PR

himanshujane3 commented 3 years ago

Hi @benzaremean As updated in my previous comment. This changes is absolutely safe, could you please accept the PR

JustSittinHere commented 3 years ago

Has this been tested on the latest version of wdio? The afterTest function takes 3 params, with results being the 3rd one

https://github.com/webdriverio/webdriverio/blob/2ace7fbac3517444634c45a05b42edbbc85f3a19/packages/wdio-types/src/Services.ts#L194

Need to add the context param, otherwise passed is still undefined.

alexbradford3 commented 2 years ago

@benzaremean Is there any chance this PR gets reviewed and merged?