search

QuanergySystems / quanergy_client_ros

Quanergy ROS driver sample source
MIT License
19 stars 10 forks source link

Launch file: Parameter ns is used for the namespace and frame #14

Closed worldpotato closed 3 years ago

worldpotato commented 3 years ago

The parameter ns is used at two places.

As namespace for the published topic: https://github.com/QuanergySystems/quanergy_client_ros/blob/d0faad7294e4810bcf10f16b0c98b25fb3b17201/launch/client.launch#L8

and as name for the frame: https://github.com/QuanergySystems/quanergy_client_ros/blob/d0faad7294e4810bcf10f16b0c98b25fb3b17201/launch/client.launch#L12

Sometimes it is useful to name them differently. E.g. if you have different lidar sensors and you want to group them by setting the namespaces to something like lidar/front/quanergy1, lidar/front/quanergy2, lidar/back/quanergy3, lidar/back/quanergy4 and still have short frame names.

Currently this can be archived by using I think adding a separated parameter for the frame solves it.

rossctaylor commented 3 years ago

@worldpotato thanks for the issue report and PR. I made a comment on the PR that I think could satisfy what you want while keeping existing behavior.

rossctaylor commented 3 years ago

Merged to devel. Will release to master with the next release, hopefully in a few weeks.