Quansight-Labs / accessible-pygments

♿ Accessible pygments themes

https://quansight-labs.github.io/accessible-pygments/

BSD 3-Clause "New" or "Revised" License

12 stars 5 forks source link

MAINT - Update pre-commit hooks #45

Closed trallard closed 6 months ago

trallard commented 6 months ago

As I was reviewing some PRs I noticed our pre-commit hooks needed an update and that some files (HTML) were not being linted/formated.

Included in this PR:

Update pre-commit hooks and configs in pyproject.toml
Run linter on all files
Updates docs

There are a lot of changes as I ran the linter, so the only files needing a check are pyproject.toml and .pre-commit-config.yaml

github-actions[bot] commented 6 months ago

PR Preview Action v1.2.0 :---: :rocket: Deployed preview to https://Quansight-Labs.github.io/accessible-pygments/pr-preview/pr-45/ on branch gh-pages at 2024-03-28 15:49 UTC

Carreau commented 6 months ago

Approved, but this might conflict with other so Maybe merge later as it will be easier to rebase this (and rerun the precomit hooks) than other way around.

trallard commented 6 months ago

Good shout on the (not) merging. I added a do-not-merge label for now

Carreau commented 6 months ago

Rebased / fixed conflicts by regenerating the files.

Carreau commented 6 months ago

One thing I did not do was delete the tests/results/*.html, as it seem the new scripts don't create those, but create pngs with playwrite, should I delete them ?

gabalafou commented 6 months ago

One thing I did not do was delete the tests/results/*.html, as it seem the new scripts don't create those, but create pngs with playwrite, should I delete them ?

41 (merged) deletes the entire test/results directory, so I'm not sure why that's not a merge conflict with main

Carreau commented 6 months ago

All looks good, let's merge, I don't think it will conflicts with #33