Quansight-Labs / czi-scientific-python-mgmt

🐍 Top level project management for Scientific-Python CZI grant at Labs
https://github.com/orgs/Quansight-Labs/projects/11?query=is%3Aopen+sort%3Aupdated-desc
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Improve PyData libraries table styling #50

Open trallard opened 7 months ago

trallard commented 7 months ago

Summary

We have identified that the PyData tables styles need improving in the dark theme (and probably in the light theme too)

See https://pydata-sphinx-theme.readthedocs.io/en/latest/examples/pydata.html

smeragoel commented 5 months ago

Here are the updated designs in light and dark mode:

image

And a preview of the interactions (hover):

https://github.com/Quansight-Labs/czi-scientific-python-mgmt/assets/98317216/3bdeb80a-d71d-4d9b-84ce-acfc73535147

Figma Link

Earlier, I was using the accent colour for hover but I changed it to our secondary colour purple to maintain consistency with other components. (Default = primary, hover = secondary, focus = accent)

Feedback and suggestions welcome! 🐰

smeragoel commented 4 months ago

I am adding some blogs / resources related to data table accessibility which might help @gabalafou

  1. https://www.a11yproject.com/posts/accessible-data-tables/#example-of-an-accessible-data-table
  2. https://tink.uk/how-screen-readers-navigate-data-tables/
  3. https://brucelawson.co.uk/2020/accessible-data-tables/
  4. https://adrianroselli.com/2017/11/a-responsive-accessible-table.html