Quansight-Labs / jupyterlab-accessible-themes

♿️🎨 An access-centred implementation of the JupyterLab default themes
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

The conda-forge package is not working -- and the instructions have the wrong name for it #69

Closed mjkanji closed 1 year ago

mjkanji commented 1 year ago

Hi there!

The installation instructions for the conda package in the README are:

conda install -c conda-forge jupyterlab_accessible_themes

However, the name of the package in conda-forge is actually jupyterlab-accessible-themes (it uses dashes, not underscores).

Also, the conda version is not detected by JupyterLab correctly:

micromamba create -n temp -y python=3.10 "jupyterlab<4" jupyterlab-accessible-themes
micromamba activate temp
jupyter labextension list

# Prints:
# JupyterLab v3.6.5
# /home/ubuntu/micromamba/envs/temp/share/jupyter/labextensions
#         jupyterlab_pygments v0.2.2 enabled OK (python, jupyterlab_pygments)

Note that the accessible themes are not listed. However, the pip version works fine:

# This is a new environment
micromamba create -n temp -y python=3.10 "jupyterlab<4"
micromamba activate temp
pip install jupyterlab_accessible_themes
jupyter labextension list

# Prints:
JupyterLab v3.6.5
# /home/ubuntu/micromamba/envs/temp/share/jupyter/labextensions
#         jupyterlab_pygments v0.2.2 enabled OK (python, jupyterlab_pygments)
#         @jupyterlab-accessible-themes/jupyterlab-theme-githublight v0.1.0 enabled OK
#         @jupyterlab-accessible-themes/jupyterlab-theme-pitayasmoothie v0.1.0 enabled OK
trallard commented 1 year ago

Thanks for reporting these issues @mjkanji I am only seeing this so apologies for the delay. We are working on the package and hope to have a fix for this soon.

steff456 commented 1 year ago

This issue should be fixed with the latest release, it is already available in the conda-forge channel. @mjkanji can you please try it and let me know if you still encounter the same issue?

steff456 commented 1 year ago

Closing this issue because the package is now working on conda 🎉