Quansight-Labs / quansight-labs-site

💻 Development site and blog for Quansight Labs
https://labs.quansight.org
24 stars 44 forks source link

Hypothesis + Array API blog post #252

Closed honno closed 2 years ago

honno commented 2 years ago

This article gives a brief demo of how one would use Hypothesis to test array-consuming methods. The structure and contents is pretty much finished, but this is still a draft and thus I would recommend a proper review take place once I remove the draft status. As well as going through the checks below, I will solicit feedback and generally mull it over before this happens.

This is part of the internship series of blog posts, but do note that it's purely technical. I'll leave personal musing out of this (and possibly write something for my own personal blog to link in this article), which I'd prefer anyway and gives breathing room for fellow interns to go more personal for their blog posts.

nbviewer, GitHub's preview


Text styling

Non-text contents

Me

For every commit

honno commented 2 years ago

I'm quite happy with this now (would appreciate reviews of-course). The sheet is clear this month but note #251 might be scheduled for Sep 21. cc @melissawm

honno commented 2 years ago

Thank you Melissa for all your great feedback! Unfortunately I haven't quite got round to resolving everything, but I'll probably submit a "ready" draft tomorrow.

I took Ralf's feedback in a call today to end the blog post in a more helpful manner—I ended up talking a bit about "comparison testing", so you could look at that now... I probably need to add an extra sentence there though, as well as finish the Fin section.

My TODO seems to be:

honno commented 2 years ago

I'm happy for another review. I changed the intro slightly (to give a tiny bit more context), and added a bit more to the end.

honno commented 2 years ago

@rgommers Awesome, hope it's ready now.

honno commented 2 years ago

one sec (my force push didnt go through for some reason, so had to do it again—all good now!)

Zac-HD commented 2 years ago

Just found this - awesome post @honno! If you're still taking reviews...

honno commented 2 years ago

Glad you like it @Zac-HD :) Yeah I'd like this post to be more of a reference than anything else, so updating the traceback and referencing your paper (handy!) are definitely good ideas. Will make a new PR at some point™ and ping you for additional review.

Header image seems to have mis-rendered the colors of the Hypothesis logo - maybe the .png version would be more stable than .svg?

Haha that's intentional, thought it'd be interesting to mix in the official Array API (or rather Data APIs) colour scheme. Let me know if you'd prefer I keep with rainbow/blue Scout for this and other things going forward.

Zac-HD commented 2 years ago

Awesome, if it's a deliberate variation I love it! Ping me whenever Hypothesis feedback would be useful 😊