cudf implementation dataframe protocol

Quansight-Labs / quansight-labs-site

💻 Development site and blog for Quansight Labs

https://labs.quansight.org

23 stars 44 forks source link

cudf implementation dataframe protocol #265

Closed iskode closed 2 years ago

iskode commented 3 years ago

Text styling

[x] The blog is written with plain language (where relevant).
[x] If there are headers, they use the proper header tags in order to do so (with only one level-one header).
[x] All links describe where they link to (for example, check the Quansight labs website).
[x] Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

[x] All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
[x] If there are emojis, there are not more than three in a row.
[x] Don't use flashing gifs or videos.
[x] If it were to be read as plain text, the blog still makes sense and no information is missing.

iskode commented 2 years ago

Thank you so much @melissawm for these deep and invaluable corrections.

tonyfast commented 2 years ago

@melissawm @iskode i made some revisions to the document mostly for structure and consistency. for some reason github let me push changes directly ismael's branch which doesnt seem right. anyway the diff is here https://github.com/iskode/quansight-labs-site/commit/af15b076af06094693fdfc57811d2721bad21153 the changes i made are:

heading structure for navigation and clarity
consistent use of the inline code for software packages
consistent use of the dataframe interchange protocol consistent with the spec.
some minor grammar structure changes.

is there anything y'all think needs to be completed before the we publish this work?

iskode commented 2 years ago

Thank you @tonyfast for your corrections and improvements. I think @melissawm best fits to give the final OK.

tonyfast commented 2 years ago

i've resolved you comments @melissawm . do you think this is ready to merge?

melissawm commented 2 years ago

That's fine with me, if that fits the general blog calendar :) Thanks @iskode !

iskode commented 2 years ago

Thank you so much @tonyfast and @melissawm for all these corrections.

iskode commented 2 years ago

Thank you @rgommers for your review.

I'm not sure I understand what is meant by "which is a safe path to preserve library specific features". Isn't it the opposite? from_dataframe should be library-independent. You've made me realized a gap in my understanding about the feature preservation. As I'm thinking now I can't see an example where converting say Vaex dataframe into CuDF dataframe using to_pandas/from_pandas will create a dataframe object with missing features than using the protocol. So I removed this part.

All the remaining suggestions and corrections have been applied.

rgommers commented 2 years ago

@tonyfast can we publish this today or tomorrow?

tonyfast commented 2 years ago

i'm merging this now, we'll share it internally to see if there are any last minute comments, and we'll promote later tomorrow/wednesday

rgommers commented 2 years ago

🎉 nice work @iskode!

iskode commented 2 years ago

tada nice work @iskode!

Thank you so much @rgommers , @tonyfast and @melissawm for your inputs to make it.