add 404 errorpages to nikola - Githubissues

Quansight-Labs / quansight-labs-site

💻 Development site and blog for Quansight Labs

https://labs.quansight.org

24 stars 44 forks source link

add 404 errorpages to nikola #269

Closed tonyfast closed 2 years ago

tonyfast commented 2 years ago

this pr adds the errorpages plugin to nikola to handle 404s https://plugins.getnikola.com/v7/errorpages/

currently, the 404 is very bare bones. see the image below

what would y'all like to see before merging this? or do we merge it and worry about style later because the current experience is ambiguous

resolves #259

cloudflare-pages[bot] commented 2 years ago

Deploying with Cloudflare Pages

Latest commit:	`5cf3e7c`
Status:	✅ Deploy successful!
Preview URL:	https://6ee70fa3.quansight-labs-site-6s3.pages.dev

rgommers commented 2 years ago

or do we merge it and worry about style later because the current experience is ambiguous

Yes, that seems like a good idea. This is an improvement, so let's get it in - bare bones works for me.