Quansight-Labs / quansight-labs-site

💻 Development site and blog for Quansight Labs
https://labs.quansight.org
23 stars 44 forks source link

Added internship wrap blog about Grayskull #285

Closed ForgottenProgramme closed 2 years ago

ForgottenProgramme commented 2 years ago

Text styling

Non-text contents

netlify[bot] commented 2 years ago

✔️ Deploy Preview for admiring-northcutt-a5be8c ready!

🔨 Explore the source changes: 3506a3c4caf2dd1f41ca38bed61df4cce58f2f32

🔍 Inspect the deploy log: https://app.netlify.com/sites/admiring-northcutt-a5be8c/deploys/61e6b9aca651c30007153f59

😎 Browse the preview: https://deploy-preview-285--admiring-northcutt-a5be8c.netlify.app

ForgottenProgramme commented 2 years ago

Thanks Mahe! It captures your work nicely while keeping it enjoyable for all audiences. The gentle introduction to the topic is perfect! The tone is spot on, as usual.

I did add some suggestions to organize the content a bit better (especially, where recipes are discussed), and amended some typos. Let me know if there's clarification needed! Also, do check the final version after all the suggestions, because with all those diffs I might have left a word here and there where it doesn't belong 😬

PS: Thanks for the ultra nice words in your personal blog :)

Thankyou @jaimergp for the detailed review and suggestions. :) I have incorporated your suggestions.

jaimergp commented 2 years ago

Looks fantastic @ForgottenProgramme! Let's wait for a 2nd pair of eyes 👀 to take a look at the post.

Direct link for your convenience: https://deploy-preview-285--admiring-northcutt-a5be8c.netlify.app/blog/2021/12/conda-recipe-grayskull/

ForgottenProgramme commented 2 years ago

Add some links and mention PyPI earlier in the blog.

Thankyou, @mattip for the review. Changed as suggested! :)

mattip commented 2 years ago

LGTM. It might be nice to mention GraySkull in the title.

ForgottenProgramme commented 2 years ago

LGTM. It might be nice to mention GraySkull in the title.

Good idea! Done.

ForgottenProgramme commented 2 years ago

awww i ❤️ how relatable your experiences are. this is right amount of technology and mahe. i really appreciated this post, and i like the literary devices that you employed.

Thankyou for the kind words, @tonyfast ! :))

i did have a hard time keep track of all the actors like conda, conda-build, pypi. is there a definition or list section that could prepended or appended to help readers keep track of the characters? could this reference @jaimergp packaging definitions?

Yes. I think that's a good idea! Maybe I should create a small table at the beginning of the blog with all the packaging terms and their one line definitions that serves as a quick reference for the reader. And maybe at the bottom we can add a link to Jaime's packaging dictionary? @jaimergp, what do you think?

trallard commented 2 years ago

@jaimergp @ForgottenProgramme what is the status of this PR? can we move it forward to get this merged?

ForgottenProgramme commented 2 years ago

Thankyou, @melissawm for your feedback. I have updated the alt texts. Please let me know if you think it can be improved further.

ForgottenProgramme commented 2 years ago

@jaimergp @ForgottenProgramme what is the status of this PR? can we move it forward to get this merged?

Hey, @trallard! I have made the suggested changes.

Thanks everyone for the feedback and suggestions. :) <3 And sorry about the delay, I was keeping busy last month with college stuff and exams and the blog slipped from my mind.

jaimergp commented 2 years ago

Do we need to move this to 2022/01 now? Is the filename of the post file accurate? I think that will become part of the URL.

rgommers commented 2 years ago

Do we need to move this to 2022/01 now? Is the filename of the post file accurate? I think that will become part of the URL.

yes indeed

jaimergp commented 2 years ago

@ForgottenProgramme One last thing sorry! See comments above.

ForgottenProgramme commented 2 years ago

@jaimergp Done!

trallard commented 2 years ago

🎉 this post seems ready to publish - I just went ahead and changed the date to 19/01/22 - if all looks good in the preview I will go ahead and merge