Quansight-Labs / quansight-labs-site

💻 Development site and blog for Quansight Labs
https://labs.quansight.org
24 stars 44 forks source link

Blogpost: The evolution of SciPy CLI #322

Closed sayantikabanik closed 2 years ago

sayantikabanik commented 2 years ago

Text styling

Non-text contents

netlify[bot] commented 2 years ago

Deploy Preview for admiring-northcutt-a5be8c ready!

Name Link
Latest commit af981137539e6c95df11754007a00b19ddd818f6
Latest deploy log https://app.netlify.com/sites/admiring-northcutt-a5be8c/deploys/627912b3e2023f00094df79a
Deploy Preview https://deploy-preview-322--admiring-northcutt-a5be8c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rgommers commented 2 years ago

This looks pretty decent now. Let me ask for review from someone who doesn't know how the project happened to make sure the story is actually clear without that context. @noatamir would you be able to review this blog post?

noatamir commented 2 years ago

Happy to! by when -ish? 😇

rgommers commented 2 years ago

Thanks @noatamir. Not super urgent, but within the next week would be great - and then squash-merge if it all looks good. Or if you prefer I do the final check & merge, then by Friday (I'm on holiday from Sat onwards).

noatamir commented 2 years ago

I left some suggestions and comments. I'm about half way through and need to stop for today.

noatamir commented 2 years ago

continuing now 😊

sayantikabanik commented 2 years ago

Thanks a ton, @noatamir ✨ I shall make the required re-writes and commit the suggestions.

sayantikabanik commented 2 years ago

Thanks again @noatamir for the detailed feedback, I have updated the required sections of the blogpost.

noatamir commented 2 years ago

Let me know when you're ready to publish. Looks great to me!

sayantikabanik commented 2 years ago

Let me know when you're ready to publish. Looks great to me!

Super excited 💃🏽, about my first blog with Quansight. Do I need to follow any additional steps for the deployment to though successfully?

noatamir commented 2 years ago

It's my first time squash-merging on the blog so we will both find out together 😄 All the checks are green so I think it should be fine 👍 I will do this a bit later when I have more time I need to prepare for a meeting.

rgommers commented 2 years ago

Yay, nice post 🎉!

@noatamir I'm not sure how, but something didn't go quite right here: you managed to do both a squash-merge (in commit 4177e2c1b2) and a regular merge of the branch after that (in commit 3ee0fa70). The normal way of doing this is to select "Squash and merge" for the green button, hit that, and then do nothing else.

There's no other commits on top yet, so I think I'll fix up the history by resetting main to commit 4177e2c1b2, to get rid of the 29 extra commits.