search

Quansight-Labs / uarray

A general dispatch and override mechanism for Python.
https://uarray.org/
BSD 3-Clause "New" or "Revised" License
101 stars 26 forks source link

Non-coercible Dispatchables #166

Closed peterbell10 closed 5 years ago

peterbell10 commented 5 years ago

An observation based on the unumpy code https://github.com/Quansight-Labs/uarray/blob/1fc6b68cbfbac12b6ff041a6a1a584feeaa8d2a8/unumpy/multimethods.py#L335-L338

If the out parameter is coerced to another type, then the result is not going to be written into the out param at all.

I think that either: out shouldn't really be a Dispatchable, or there needs to be some way of marking the parameter as non-coercible.

hameerabbasi commented 5 years ago

there needs to be some way of marking the parameter as non-coercible.

Done in #160.