search

Quansight / Quansight-website

💻 Source code for Quansight Labs website
https://labs.quansight.org
20 stars 50 forks source link

[BUG] - blog post on PyData GPU extensibility has two issues #405

Open rgommers opened 2 years ago

rgommers commented 2 years ago

What site is this for?

Quansight Labs

Expected behavior

I see two issues with https://labs.quansight.org/blog/pydata-extensibility-vision:

  1. The header image is very weird and off-putting. I think it's actually better to remove that header image completely, because it takes up too much space and is highly unusual for a single blog post page. But if the design idea stays, a more suitable image should be chosen.
  2. This was a two author post, Ivan Yashchuk (@ivanyashchuk) and me. Now I see Ivan has disappeared as a main author. Can we please fix that?

Actual behavior

image

How to Reproduce the problem?

Go to https://labs.quansight.org/blog/pydata-extensibility-vision

Anything else?

No response

bskinn commented 2 years ago

@rgommers Your (2) is blocked pending #182. ~I'll add this as~ This is already a TODO bullet in #364.

bskinn commented 2 years ago

Attn: @trallard @irinafumarel

noatamir commented 2 years ago

@rgommers just to clarify, would you like to discuss changing the design template so that all posts don't require a header (hero) image? Or it just bothers you in this case?

Asking because if it's the latter we can replace it with a generic image using a template Irina already provided us with.

But for the former it will require dev effort because at the moment, as best I recall, the post won't build without a hero image.

rgommers commented 2 years ago

I think it's either completely unnecessary or taking up too much vertical space in general. So it'd be good to improve that. But in this case it particularly jumps out, so if there's no appetite for design changes any time soon, replacing with the stock image would be nice.

irinafumarel commented 2 years ago

@rgommers I agree. I'll work with @noatamir to replace those placeholders with either proper illustrations or stock photos

noatamir commented 2 years ago

I agree as well. We'd be happy to get back to this ☺️. It's on our list of things we haven't finished tweaking and are waiting to get back to when time allows.

@MarsBarLee could you meanwhile open a PR to replace the hero with one of Irina's illustrations? I think this could be a good patch until long-term changes are implemented. (If I recall, we also discussed this when the PR was made, and you weren't sure about the cropped diagram either).

PS, yesterday I created a few more variations and placed them in our shared folder. So you have more options to work with 😉.