Fix omniscidb import - Githubissues

xmnlab commented 3 years ago

This PR aims to prepare the code and the notebooks to work with the new ibis version 1.4

Resolves #75

This PR:

Fixes build issues:
- changes environment.yml file with pinnings that will not have conflicts with the package installation (setup.py)
- update typescript pinning to fix issues with jest https://github.com/facebook/jest/issues/9703#issuecomment-724006533
Fixes test issues
- set browserExecutablePath just when OS is Darwin
- updates and add test data (chart images)
- fixes test parameter
Fixes CI issues
- changes "goanpeca/setup-miniconda@v1" to "conda-incubator/setup-miniconda@v2"
Fixes ibis import (using the new package structure eg: from ibis.backends import omniscidb)

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

xmnlab commented 3 years ago

PS: after this PR is merged, we need a new release on pypi.

Quansight / ibis-vega-transform