search

Quansight / lsst_dashboard

LSST Dashboard https://quansight.github.io/lsst_dashboard/
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Group visit line plots in tabs by filter. Different metrics from the same filter should be overlays, but different filters, if present, should spit into tabs. #107

Closed brendancol closed 4 years ago

brendancol commented 4 years ago

Group visit line plots in tabs by filter. Different metrics from the same filter should be overlays, but different filters, if present, should spit into tabs.

brendancol commented 4 years ago

Tabs have been added to the detail plot.

@chbrandt @philippjfr there might be a bug on the holoviews side which we'd like to chat about.

When changing filter tabs on the detail screen, the axes of the visit plot don't update correct.

@chbrandt is going to create a reproduction case

chbrandt commented 4 years ago

The bug/feature was bypassed by giving a unique name for the x-axis of each filter in the visits plot: e.g. visits (HSC-G). Before, all plots -- in each different tab (separated after the filter label) -- had the same (internal) label for x-axis, visit; When put together in a Tab container the values whould be concatenated.

chbrandt commented 4 years ago

Commit https://github.com/Quansight/lsst_dashboard/commit/29ace33b7c6b5fa092af74a31257b534f736cfa4 fix this issue. @brendancol