Quansight / lsst_dashboard

LSST Dashboard https://quansight.github.io/lsst_dashboard/
BSD 3-Clause "New" or "Revised" License
8 stars 3 forks source link

Linked scatter/sky plots not working #99

Closed timothydmorton closed 4 years ago

timothydmorton commented 4 years ago

The linked plots in detail view do not work. I have tested with both panel current master and 0.7.1a2, (holoviews 1.12.7) and am seeing the following behavior:

@philippjfr I don't know how closely you had been following the development of the linked plots for this project, but @dharhas mentioned to me in December that some of the ideas tested out here were going to be included in future (present?) holoviz releases. Is it possible that recent updates to the holoviz code may have broken some of the linking code that @brendancol had done here?

philippjfr commented 4 years ago

I'm not aware of any changes, those warnings you are seeing are also unrelated. Indeed the versions you are testing are largely unchanged from those that were used at the time this was implemented. I'll likely take a look at it today or tomorrow since I'm hoping to release panel 0.8 tomorrow.

dharhas commented 4 years ago

@philippjfr There is a test dataset I used at Pydata Austin that is in the right format to use with the latest LSST code. It is located here: https://quansight.nyc3.digitaloceanspaces.com/datasets/lsst/DM-21335-1Perc.tar.gz

Let me know if you need help debugging.

timothydmorton commented 4 years ago

Thanks guys- I have just confirmed the same issue exists with the small test dataset. Because of the smaller load times, I've tried several times, and occasionally one of the plots might have working tools, but mostly the tools seem totally inactive. For example, even if I start out in detail view and select Gaussian-PSF from one band, the tools do not seem to be active on either figure.

philippjfr commented 4 years ago

Could you try again using Panel v0.8.0a1 before I dive in?

timothydmorton commented 4 years ago

OK, with v0.8.0a1 it looks like if I turn off then back on the pan tool (mimicking what Dharhas did in the Austin talk), then things might work as expected? But before doing that, nothing. If indeed that is all that is required to make things work (and that works reliably), then this is just a minor bug, but if you can figure out what's happening @philippjfr that would be awesome, thanks!

philippjfr commented 4 years ago

OK, with v0.8.0a1 it looks like if I turn off then back on the pan tool (mimicking what Dharhas did in the Austin talk), then things might work as expected?

This is a bokeh toolbar bug which can hopefully be resolved soon.