search

Quansight / omnisci

Explorations on using MapD and Jupyter together.
4 stars 1 forks source link

Ibis OmniSciDB UDF support for Numeric data types for elementwise operation #125

Closed xmnlab closed 3 years ago

xmnlab commented 4 years ago

PR in progress: https://github.com/ibis-project/ibis/pull/2274

xmnlab commented 3 years ago

https://github.com/ibis-project/ibis/pull/2274 waiting for the first review

kcpevey commented 3 years ago

There is one failing CI on this. They are likely waiting for it to be resolved before reviewing.

xmnlab commented 3 years ago

it seems there are some problems with the omniscidb docker-compose related to the "new" ci structure.

 /usr/bin/docker create --name 78b67a01edaa4835a32466a6a6234a56_omniscicoreoscpuv522_793a76 --label 8118cb --network github_network_25cd0445b9e5420a82b03f5817dd8c2f --network-alias omnisci -p 6274:6274 -p 6278:6278  -e GITHUB_ACTIONS=true -e CI=true -v "ci/omniscidb.conf":"/omnisci-storage/omnisci.conf" omnisci/core-os-cpu:v5.2.2
  Error response from daemon: create ci/omniscidb.conf: "ci/omniscidb.conf" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path
  ##[error]Exit code 1 returned from process: file name '/usr/bin/docker', arguments 'create --name 78b67a01edaa4835a32466a6a6234a56_omniscicoreoscpuv522_793a76 --label 8118cb --network github_network_25cd0445b9e5420a82b03f5817dd8c2f --network-alias omnisci -p 6274:6274 -p 6278:6278  -e GITHUB_ACTIONS=true -e CI=true -v "ci/omniscidb.conf":"/omnisci-storage/omnisci.conf" omnisci/core-os-cpu:v5.2.2'.
xmnlab commented 3 years ago

an alternative would be to have a custom image that will include this omniscidb.conf

xmnlab commented 3 years ago

done at omnisci/ibis-omniscidb https://github.com/omnisci/ibis-omniscidb/pull/11