Closed xmnlab closed 3 years ago
Also, as pointed by @israelvicars, answering the question I asked at https://github.com/Quansight/omnisci/issues/145#issuecomment-772724507, it should create a symlink for omnisci-examples to ~/Documents
.
@israelvicars these changes are included into the release 0.1.3 https://github.com/Quansight/omnisci-datascience-installer/releases/tag/0.1.3
I tested the sh
package locally and the notebooks are working. I just noticed that there are 2 notebooks that explain how to start a docker container with OmniSciDB that is using an old version (v5.2) and it should be updated to at least v5.4 (because some notebooks uses UDF). I will open an issue here for that.
you can test it using the command jupyter-lab --notebook-dir $HOME/Documents/omnisci-examples
could you check if it is working as requested?
The new target directory is omnisci-datascience (default using the name of the pacakge) https://github.com/Quansight/omnisci-datascience-installer/blob/master/constructor/pkg/construct.yaml#L1
the notebook folders are installed into the ~/Documents folder:
What is the high level objective of the work
The target directory should be changed to ${HOME}/omnisci-datascience
What should the final state look like
Set
default_prefix
to${HOME}/omnisci-datascience
for the constructor.yaml for both pkg and sh packages recipe. Also theconda_activate.sh
script should be updated.What are all the different things that need to be done
If it is needed, the dependencies should be updated.
Who are the stakeholders for the different pieces that might need to clarify things
@israelvicars @andrewseidl
What does success look like?
The new package should install by default the meta package to ${HOME}/omnisci-datascience