Quansight / omnisci

Explorations on using MapD and Jupyter together.
4 stars 1 forks source link

Implement support for UDF array arguments #39

Closed dharhas closed 4 years ago

dharhas commented 5 years ago

Currently, UDFs support only scalar arguments, that is, UDFs are applied by row. Implement support for UDF array arguments, this task is dependent on availability of OmniSci staff to implement prerequisite functionality

pearu commented 5 years ago

Created https://github.com/omnisci/omniscidb-internal/pull/3726 Example of a UDF with array arguments: https://github.com/xnd-project/rbc/blob/master/notebooks/rbc-omnisci-array.ipynb

pearu commented 5 years ago

Half-blocker: https://github.com/numba/numba/issues/4546 (has a temporary workaround).

pearu commented 5 years ago

In a sense, this issue is completed once the PR 3726 is merged. The merge is blocked by https://github.com/omnisci/omniscidb-internal/pull/3695 that needs to be merged first, then rebase and merge https://github.com/omnisci/omniscidb-internal/pull/3726 .

For sustainable support of UDF array arguments, https://github.com/numba/numba/issues/4546 needs to be resolved (estimated time: 40h)

For the next phase, I suggest implementing support for UDF geo arguments (estimated time: 40h)

Abaal commented 5 years ago

Numba issue that needs to be done, half done half blocked by Numba work

pearu commented 4 years ago

Moved the numba issue to #69 and closing this one as complete.