search

Quansight / omnisci

Explorations on using MapD and Jupyter together.
4 stars 1 forks source link

Eliminate usage of boost headers in CUDA sources [omniscidb-internal] #83

Closed pearu closed 4 years ago

pearu commented 4 years ago

Original issue: https://github.com/Quansight/pearu-issues/issues/12

When using conda environment, building omniscidb requires overriding nvcc with a script that includes boost include directories to the nvcc include path. This workaround is also used in https://github.com/conda-forge/omniscidb-cuda-feedstock/

The actual problem is that boost headers are included in CUDA sources that is not generally desired. The PR https://github.com/omnisci/omniscidb-internal/pull/3984 fixes this issue properly. Omnisci has been ping several times about the PR but with little response.

TODO:

pearu commented 4 years ago

@rpekrul @dharhas can you push buttons on this issue?

pearu commented 4 years ago

The PR got merged.