search

Quansight / omnisci

Explorations on using MapD and Jupyter together.
4 stars 1 forks source link

[IBIS] Add NTile window operation #88

Open xmnlab opened 4 years ago

xmnlab commented 4 years ago

refs:

xmnlab commented 4 years ago

waiting for review: https://github.com/ibis-project/ibis/pull/2146

kcpevey commented 4 years ago

This PR ibis-project/ibis#2146 has been reviewed (7/20/20) and changes are requested

xmnlab commented 4 years ago

PR https://github.com/ibis-project/ibis/pull/2146 was rebased, suggestions from the review were applied, waiting for feedback from the reviewer.

xmnlab commented 3 years ago

waiting for feedback since then, now it needs to be rebased. but it is hard to keep the PR rebased each time for this very long review (2 months without any feedback). maybe the right strategy now is to help the move omniscidb backend to an own repo (https://github.com/ibis-project/ibis/issues/2356) and probably the review workflow would be much more fluid.

any thought @datapythonista ?

datapythonista commented 3 years ago

My bad, I approved the PR, but forgot to remind Jeff, didn't see it's been that long. If you want to fix the conflicts that moving omnisci caused, I'll try to get this merged soon.

xmnlab commented 3 years ago

no worries @datapythonista I will do it in a bit, thanks!.