[IBIS] Implement percent_rank and cume_dist properly to ibis.omniscidb

Quansight / omnisci

Explorations on using MapD and Jupyter together.

4 stars 1 forks source link

[IBIS] Implement percent_rank and cume_dist properly to ibis.omniscidb #89

Open xmnlab opened 4 years ago

xmnlab commented 4 years ago

refs:

https://github.com/pandas-dev/pandas/issues/28975

xmnlab commented 4 years ago

wip: https://github.com/ibis-project/ibis/pull/2224

kcpevey commented 4 years ago

Looks like this PR ibis-project/ibis#2224 has been reviewed with an assumed approval after changes were made, but the CI is still breaking. Fixing the CI may be the last step to getting this pushed through.

xmnlab commented 4 years ago

PR https://github.com/ibis-project/ibis/pull/2224 approved by @datapythonista . it is waiting for jreback review.

kcpevey commented 3 years ago

@xmnlab Looks like you have some conflicting files now.

xmnlab commented 3 years ago

the PR was blocked until we have some real use case to prove the necessity of this change.

an alternative would be split this PR into 2 PRs, one for each implementation.