Quansight / open-gpu-server

The Open GPU Server for CI purpose.
8 stars 12 forks source link

Github usernames vs identifier #14

Closed jaimergp closed 9 months ago

jaimergp commented 9 months ago

AFAIK, users can change their GH handle, but there's an int identifier that is immutable and guaranteed to be unique.

@aktech - how does cirun perform the check? Just string comparison? Or do we check the IDs anywhere? I assume we would have to include the id in the JSON to actually ensure that it's the trigger username is the same account that was enabled via PR, and not another that took over. Quite the edge case, I know, but just wondering.