#458 Automate Docker Requirements Workflow for PR Creation and Review Requests

Quansight / ragna

RAG orchestration framework ⛵️

https://ragna.chat

BSD 3-Clause "New" or "Revised" License

181 stars 22 forks source link

#458 Automate Docker Requirements Workflow for PR Creation and Review Requests #459

Closed arjxn-py closed 4 months ago

arjxn-py commented 4 months ago

Should Fix #458

This PR updates the Docker requirements workflow to:

Automatically create PRs to update requirements-docker.lock when changes are detected.
Dynamically request reviews from the author and the person who merged the last PR into main.

I've also tested this updated workflow a number of times on my fork to-

Here's the test workflow run
Here's the automatically created PR when I bumped down panel==1.4.2 on my fork for testing.

arjxn-py commented 4 months ago

We should also set a repository secret with name GH_TOKEN that would most likely be a fine grained access token. cc: @pmeier

arjxn-py commented 4 months ago

Here'a a better test run - https://github.com/arjxn-py/ragna/actions/runs/10183204935/job/28167581020

& the sample PR that's been opened as a result - https://github.com/arjxn-py/ragna/pull/10

arjxn-py commented 4 months ago

We also need to think of a mechanism to surface a failure of this workflow somehow, because if we never get PRs that could also mean that the workflow is broken. So maybe use an action that opens an issue on failures?

I'm on it to create this step.

Question: if there are No PR's, there's no update on dependencies. Does requirements-docker.lock still needs updates in that case?

pmeier commented 4 months ago

if there are No PR's, there's no update on dependencies. Does requirements-docker.lock still needs updates in that case?

No. If we (sadly) ever get to the point where there are no commits on this repo anymore, there is also no need to update docker requirements. If that somehow is needed for some reason, you can also do git checkout main && git commit -m 'trigger CI' --allow-empty && git push.

arjxn-py commented 4 months ago

No. If we (sadly) ever get to the point where there are no commits on this repo anymore, there is also no need to update docker requirements. If that somehow is needed for some reason, you can also do git checkout main && git commit -m 'trigger CI' --allow-empty && git push.

I don't think we need git checkout main && git commit -m 'trigger CI' --allow-empty && git push or it'd help as we have certain files that trigger this workflow. But it should be a nice thing to configure something like dependabot, I believe this workflow would compliment it nicely. And also keep the project updated.