Use Globals for credentials access for subscription validation - Githubissues

QuantConnect / Lean.Brokerages.Binance

Binance Brokerage Plugin

Apache License 2.0

5 stars 18 forks source link

Use Globals for credentials access for subscription validation #33

Closed jhonabreul closed 8 months ago

jhonabreul commented 8 months ago

Description

Use Globals for credentials access for subscription validation. This follows https://github.com/QuantConnect/Lean/pull/7796

Additionally, subscription validation was moved up before any IB connection is done.

Related Issue

N/A

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

Integration with Lean

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>