This pull request addresses an issue with the data downloader for the Bybit brokerage plugin of Lean environment. The problem stemmed from an exception where the downloader couldn't be initialized due to the absence of a parameterless constructor. To resolve this, I've implemented a parameterless constructor, fixing the bug.
Related Issue
20
Motivation and Context
The motivation behind this fix is to ensure that the data downloader for Bybit follows the expected pattern and behavior set by other brokerage implementations in Lean. By providing a parameterless constructor, we enable smoother initialization of the downloader, eliminating the previously encountered exception.
Requires Documentation Change
N/A
How Has This Been Tested?
To validate the fix, I created a dotnet package of QuantConnect.BybitBrokerage.ToolBox and locally ran lean data download with --data-provider-historical ByBit. The test was successful, and I have attached a screenshot for reference.
Downloading process
Keep on disc (compare with screen above)
Time Zone Conversion: Upon checking the timestamp of the provided screenshot against my local time, I adjusted it to UTC by subtracting three hours.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
This pull request addresses an issue with the data downloader for the Bybit brokerage plugin of Lean environment. The problem stemmed from an exception where the downloader couldn't be initialized due to the absence of a parameterless constructor. To resolve this, I've implemented a parameterless constructor, fixing the bug.
Related Issue
20
Motivation and Context
The motivation behind this fix is to ensure that the data downloader for Bybit follows the expected pattern and behavior set by other brokerage implementations in Lean. By providing a parameterless constructor, we enable smoother initialization of the downloader, eliminating the previously encountered exception.
Requires Documentation Change
N/A
How Has This Been Tested?
To validate the fix, I created a dotnet package of
QuantConnect.BybitBrokerage.ToolBoxand locally ranlean data downloadwith--data-provider-historical ByBit. The test was successful, and I have attached a screenshot for reference.Downloading process
Keep on disc (compare with screen above)
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>