TDAmeritradeBrokerage Support

bmello4688 commented 2 years ago

Description

Supports the following features for TDAmeritrade Brokerage:

Enables subscription of DataFeeds Live Trading Historical Data Fetch ToolBox Downloader

Related Issue

Closes: QuantConnect/Lean#4647

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

nuaimat commented 2 years ago

Hi, what's the timeframe to have this in prod, please?

bmello4688 commented 2 years ago

Hi Mo,

It needs to be tested and the bugs ironed out. I’m not sure how long it will take. You can certainly pull it and use it then report any issues back to me.

Brian

From: Mo Nuaimat @.> Sent: Saturday, November 13, 2021 11:28:25 PM To: QuantConnect/Lean.Brokerages.TDAmeritrade @.> Cc: bmello4688 @.>; Author @.> Subject: Re: [QuantConnect/Lean.Brokerages.TDAmeritrade] TDAmeritradeBrokerage Support (PR #1)

Hi, what's the timeframe to have this in prod, please?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/QuantConnect/Lean.Brokerages.TDAmeritrade/pull/1#issuecomment-968203894, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3WTQXZ6WPOVZKGS6XDSYDUL43GTANCNFSM5GLWAVYA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jaredbroad commented 2 years ago

@Martin-Molinero it would be nice to start a review on this one.

ikamanu commented 2 years ago

👏

QuantConnect / Lean.Brokerages.TDAmeritrade