#2 Some Fixes - Githubissues

QuantConnect / Lean.Brokerages.TDAmeritrade

TD Ameritrade Brokerage Plugin

14 stars 9 forks source link

#2 Some Fixes #4

Closed Romazes closed 1 year ago

Romazes commented 1 year ago

Description

Updates the type of brokerage factory to TDAmeritradeBrokerageFactory
Fix multiple subscription/unsubscription to symbols
Setup Date.Time to TimeZones.NewYork
Keep userPrincipals in private variable (Now, we can do one request when login to system)
Fix: getExchangeSymbol() (BF-B -> BF.B)
Fix: WaitWebSocketResponse event. If we cannot get response from websocket then algorithm will stop.

Related Issue

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Run test in test project.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>