Fixing memory leaks in the conversion of some types - Githubissues

QuantConnect / pythonnet

Python for .NET is a package that gives Python programmers nearly seamless integration with the .NET Common Language Runtime (CLR) and provides a powerful application scripting tool for .NET developers.

http://pythonnet.github.io

MIT License

28 stars 26 forks source link

Fixing memory leaks in the conversion of some types #14

Closed Martin-Molinero closed 6 years ago

Martin-Molinero commented 6 years ago

What does this implement/fix? Explain your changes.

For TimeSpan, Decimal, DateTime and private static IntPtr TzInfo(DateTimeKind kind) added a few of Runtime.XDecref to free memory

There is still some memory leak happening.

Does this close any currently open issues?

Required for https://github.com/QuantConnect/Lean/issues/2288

Any other comments?

Tested with pythonnet unit tests, Lean python regression tests and manually with python algorithm.

Checklist

Check all those that are applicable and complete.

[ ] Make sure to include one or more tests for your change
[ ] If an enhancement PR, please create docs and at best an example
[ ] Add yourself to AUTHORS
[ ] Updated the CHANGELOG

jaredbroad commented 6 years ago

Thanks @Martin-Molinero