search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

Implement Theme Support #181

Closed AtlasMaxima-zz closed 6 years ago

AtlasMaxima-zz commented 6 years ago

  1. Added script to run the command concurrently with gulp to compile SCSS to CSS on npm run dev for now unless we change the command name.

  2. Added dynamical component for landing logos to make it more open source. As of now, Devs/Users can go into /client/src/assets/img/logo and place their png and jpg for what they want their landing logos to be and in /client/src/imageData.json to put in the name of the images and their desired className.

  3. SCSS folder /scss/src has been organised.

mmcky commented 6 years ago

thank @AtlasMaxima - looking good - I will take a closer look at this.

In the future it would be great if you could split PR's into smaller units (i.e. 1 for ranking algorithm, 1 for theme support, 1 to fix npm) that helps with keeping the simple ones moving while we discuss design issues on others etc. But don't change this one - we will just update the name. Also I typically squash and merge so if we need to we can just undo one commit on master etc.

Thanks for your work on this.

mmcky commented 6 years ago

@AtlasMaxima nice variable names.

@DrDrij are you happy with this approach to using variables throughout the css files?

mmcky commented 6 years ago

hey @AtlasMaxima I know it's a pain - but thanks for breaking up this PR. Once non-theme related items are removed can you let @DrDrij know as we will no doubt iterate on this to converge to a good solution re: theme layout and specs etc.