search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

notification for users after clicking invite button for successful invite on client side #174 #188

Closed AtlasMaxima-zz closed 6 years ago

AtlasMaxima-zz commented 6 years ago

invite notification will pop up after users click on 'Submit' after completing the 'Invite' form for website notification on client side.

i.e. green success box will appear after the user submits the email to invite

mmcky commented 6 years ago

Thanks @AtlasMaxima. I know its a pain but please be a bit more verbose with the descriptions and summary. Is this for email notifications or for website notifications once invite users has been submitted? I ask as if mailgun we should test this on the development instance to check mailgun is working etc. for dispatching email notifications.

Looking good. Well done on splitting that PR apart!

mmcky commented 6 years ago

hey @AtlasMaxima when you get a chance can you let me know answers to the above questions?

AtlasMaxima-zz commented 6 years ago

This was for website notification on the client side but I will create another issue for the mailgun which is the server side after implementing the email authenticity on the client side which will set more constraints beforehand.

mmcky commented 6 years ago

great - thanks @AtlasMaxima. The main issue on the email side is with the template. I think we just need to swap it over to use html in the message rather than markdown. We will just need to amend the merge conflict in HEAD.jsx if you're happy with this PR.