search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

Theme support #191

Closed AtlasMaxima-zz closed 6 years ago

AtlasMaxima-zz commented 6 years ago

1.Added script to run the command concurrently with gulp to compile SCSS to CSS on npm run dev for now unless we change the command name.

2.Added dynamical component for landing logos to make it more open source. As of now, Devs/Users can go into /client/src/assets/img/logo and place their png and jpg for what they want their landing logos to be and in /client/src/imageData.json to put in the name of the images and their desired className.

3.SCSS folder /scss/src has been organised.

mmcky commented 6 years ago

thanks @AtlasMaxima -- this is looking a lot cleaner. I'll take a closer look over the next few days. Let's discuss this on Thursday when we catch up.

@DrDrij are you happy with the structure here with the aim to better support themes in bookshelf?

mmcky commented 6 years ago

thanks for review @DrDrij. Before merging this - @AtlasMaxima the last step is we will need to document how to setup a theme. @DrDrij are you able to work on a generic theme for Bookshelf now?

DrDrij commented 6 years ago

@mmcky Are we thinking a theme with a dummy logo and maybe simple blue colour scheme? Is it necessary? @AtlasMaxima Wondering how/where it could live within the source?

AtlasMaxima-zz commented 6 years ago

@DrDrij we can place the generic theme inside of the client/src/assets/themes directory which the themes directory do not exist so we would have just create one? What do you think?

One idea would be allowing devs/maintainers to just @import... the theme that resides within that folder.

DrDrij commented 6 years ago

@AtlasMaxima I like the @import idea. Is it something you could help implement?

AtlasMaxima-zz commented 6 years ago

@DrDrij Yes I will try my best.