search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

Summary character limit #193

Closed AtlasMaxima-zz closed 6 years ago

AtlasMaxima-zz commented 6 years ago

Update Summary Character Limit #180 issue.

Within each notebook submission including editing the notebook, there are no limits as to how many characters.

In homepage, each notebook submission summary will only show up to 25 words and if it exceeds 25 words, trailing periods are added at the end indicating the summary is longer than what is shown.

mmcky commented 6 years ago

hey @AtlasMaxima do you think 25 words is enough for the front page? Is it possible to show some screenshots of it in action?

AtlasMaxima-zz commented 6 years ago

@mmcky I just updated the dev instance so you can check it out there in action; 25 words are about 2 lines. Let me know if we want to change it to more than 25 or less.

mmcky commented 6 years ago

hey @AtlasMaxima I am not seeing any summary information at the moment on the development server. There seems to be a clickthrough bug where the summary information disappears when selecting to view the front page etc.

AtlasMaxima-zz commented 6 years ago

@mmcky the bug has been fixed now and the branch is updated on the dev for testing.

mmcky commented 6 years ago

thanks @AtlasMaxima can we bump the description up to 3 lines of text. Currently I think the summary is a bit small.

mmcky commented 6 years ago

@AtlasMaxima let's fix the max summary to 500 words and the front page / listing summary to 50 words

mmcky commented 6 years ago

hey @AtlasMaxima when you're ready with the final specs (as above) let's adjust and merge.

AtlasMaxima-zz commented 6 years ago

@mmcky it's been adjusted and a modal pop up window has also been added to let users know that the summary word limits is only 500 words excluding next lines and extra white spaces.

mmcky commented 6 years ago

nice -- thanks @AtlasMaxima when you're ready -- let's load it up on the dev server and I'll do some testing.

AtlasMaxima-zz commented 6 years ago

@mmcky -- New notebook is not saving and existing notebook cannot be edited #217 has been fixed up. Just need to test it again on the dev server whenever it's ready.

mmcky commented 6 years ago

@AtlasMaxima it looks like the summary page isn't updating when you paste content into the summary box. It seems that summary requires a keystroke to register updates in content. IT would be good to add paste as an action event also.

On the summary page - let's respect newlines

On the front page let's remove newlines to display a 50 word summary. In most cases the first 50 words will likely be before any newlines anyway.

Given many journals cap the abstract at 250 let's use 50 on the front page and 250 on the summary page. Please make these options in the configuration.

mmcky commented 6 years ago

@AtlasMaxima do I need to test this again?