search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

Center the buttons for modal window #200

Open AtlasMaxima-zz opened 6 years ago

AtlasMaxima-zz commented 6 years ago

For the modal popup window such as the two buttons Cancel & Invite, can we center the buttons a bit more.

The buttons are a bit pushed towards the left side.

screen shot 2018-08-23 at 3 14 18 pm
DrDrij commented 6 years ago

Hi @AtlasMaxima . I've applied styles to the invite modal in the 'modal-window-styles' branch.

The original styles designed for the site during prototyping are available for comparison at: http://notebooks.drdrij.com/n/an-introduction-to-the-nelder-mead-algorithm/ (Click the flag or delete icons below the score)

image

In my edits I've tried to merge the styles from the jQuery modal with React modal used for the build.

Most of work was around aligning the HTML markup on the build with that used on the prototype. I've applied the updates to the development server:

image

Does it make sense? Reckon you could use the same method for other modals?

AtlasMaxima-zz commented 6 years ago

@DrDrij It looks good! I will implement this style for the other modals. Would you want to create a PR for this ?

natashawatkins commented 5 years ago

This has been fixed right @AtlasMaxima ?