Automatically match accounts on email

QuantEcon / Bookshelf

Code for the site QuantEconLib

1 stars 0 forks source link

Automatically match accounts on email #272

Open natashawatkins opened 5 years ago

natashawatkins commented 5 years ago

We should match accounts from different logins (Github, email, etc.) on their email and merge them
As a user I would expect to only have one account if the email associated with the logins is the same

jstac commented 5 years ago

Thanks for adding this. +1

mmcky commented 5 years ago

A lot of people don't have the same email address associated between GitHub and gmail so this matching isn't going to be perfect. As a user I wouldn't assume my profile would be linked if I logged in with different OAuth services. I agree it would be a nice to have - but I downgraded this to medium priority for now (happy to be overruled).

jstac commented 5 years ago

I've logged in via google and other times via GH without thinking about it. When I last went in via google I was surprised that I couldn't find all my notebooks until I realized what was happening.

I guess one thing is to offer account deletion and the other is to offer merges based on emails. It's not perfect but I couldn't think of a better idea.

Happy to have the merge part as medium priority but perhaps allowing users to delete profiles should be high.

mmcky commented 5 years ago

I agree. Account deletion is Issue #277 and is marked high priority.

mmcky commented 5 years ago

@AtlasMaxima is working on a restore feature as a second step after implementing user deletion.