search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

Edit comment sync #297

Closed AakashGfude closed 5 years ago

AakashGfude commented 5 years ago

edited comment and replies to a comment are being shown in front end without the need to refresh (hopefully). Have also handled error in editing comment which looks like the below pic commentupdation

Have not done the same for error in replies though yet. Will do that once i get heads up for this design. Any design alterations are welcome.

jstac commented 5 years ago

Looks good, thanks. Text should be "Comment update failed. Please try again."

AakashGfude commented 5 years ago

@jstac noted.

mmcky commented 5 years ago

thanks @AakashGfude this is looking good. Would you mind tagging the issue that this PR closes?

AakashGfude commented 5 years ago

fIxes #291 fixes #253

mmcky commented 5 years ago

hey @AakashGfude this is looking good. it is great to get comment updates in sync. I had one issue in testing when disconnecting from the internet and re-connection - but I think that was more my impatience than anything as I can't seem to replicate it. I'll approve this and if it pops up again later we can apply a fix.

mmcky commented 5 years ago

@AtlasMaxima can this be merged now?

AtlasMaxima-zz commented 5 years ago

@mmcky @AakashGfude seems like there is a conflict with the main.min.css